Re: [PATCH 13/21] KVM: x86/mmu: Pass around full 64-bit error code for KVM page faults

From: Sean Christopherson
Date: Mon Mar 04 2024 - 10:45:04 EST


On Mon, Mar 04, 2024, Xiaoyao Li wrote:
> On 2/28/2024 7:20 AM, Paolo Bonzini wrote:
> > From: Isaku Yamahata <isaku.yamahata@xxxxxxxxx>
> >
> ...
> > The use of lower_32_bits() moves from kvm_mmu_page_fault() to
> > FNAME(page_fault), since walking is independent of the data in the
> > upper bits of the error code.
>
> Is it a must? I don't see any issue if full u64 error_code is passed to
> FNAME(page_fault) as well.

Heh, my thought as well.

https://lore.kernel.org/all/20240228024147.41573-5-seanjc@xxxxxxxxxx