Re: [PATCH net-next v2] net/nlmon: Cancel setting the fields of statistics to zero.

From: Daniel Borkmann
Date: Mon Mar 04 2024 - 08:57:35 EST


On 3/4/24 2:25 PM, Jason Xing wrote:
On Mon, Mar 4, 2024 at 7:14 PM yuanli fu <fuyuanli0722@xxxxxxxxx> wrote:
Jason Xing <kerneljasonxing@xxxxxxxxx> 于2024年3月4日周一 15:05写道:
On Sun, Mar 3, 2024 at 7:43 PM fuyuanli <fuyuanli@xxxxxxxxxxxxxx> wrote:

Since fields of rtnl_link_stats64 have been set to zero in the previous
dev_get_stats function, there is no need to set them again in the
ndo_get_stats64 function.

Signed-off-by: fuyuanli <fuyuanli@xxxxxxxxxxxxxx>
Link: https://lore.kernel.org/netdev/20240302105224.GA7223@didi-ThinkCentre-M920t-N000/

Suggested-by: Jason Xing <kerneljasonxing@xxxxxxxxx>
See https://lore.kernel.org/all/CAL+tcoA=FVBJi2eJgAELhWG_f+N-kwmrHc+XRfKXhYk2RJcPKg@xxxxxxxxxxxxxx/
OK, I will submit a v3 patch which updating commit message, thanks.

I don't think you need to send a new version of the patch unless
someone points out other changes that should be made.

I think this patch is not needed anymore, see net-next :

4f41ce81a919 ("net: nlmon: Remove init and uninit functions")
26b5df99bf60 ("net: nlmon: Simplify nlmon_get_stats64")

Thanks,
Daniel