Re: [PATCH V2 4/9] platform/x86/intel/sdsi: Add attribute to read the current meter state

From: Ilpo Järvinen
Date: Mon Mar 04 2024 - 08:30:03 EST


On Tue, 27 Feb 2024, David E. Box wrote:

> The meter_certificate file provides access to metering information that may
> be attested but is only updated every 8 hours. Add new attribute,
> meter_current, to allow reading an untested snapshot of the current values.
>
> Signed-off-by: David E. Box <david.e.box@xxxxxxxxxxxxxxx>
> ---
>
> V2 - make control_flags a parameter to be eventually passed to
> sdsi_mbox_cmd_read(). This removes the need for a lock which had been
> added to protect control_flags when it was a member of the private
> struct.

Yes, thanks. It's more obvious now what's going on w/o all that lock
trickery.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

--
i.