Re: [PATCH V2 2/9] platform/x86/intel/sdsi: Combine read and write mailbox flows

From: Ilpo Järvinen
Date: Mon Mar 04 2024 - 08:25:21 EST


On Tue, 27 Feb 2024, Kuppuswamy Sathyanarayanan wrote:
> On 2/27/24 4:00 PM, David E. Box wrote:
> > The current mailbox commands are either read-only or write-only and the
> > flow is different for each. New commands will need to send and receive
> > data. In preparation for these commands, create a common polling function
> > to handle sending data and receiving in the same transaction.
> >
> > Signed-off-by: David E. Box <david.e.box@xxxxxxxxxxxxxxx>
> > ---
> >
> > V2 - In sdsi_cmd_read() remove unnecessary check for non-zero packet_size
> > in do loop since the loop is exited earlier when packet_size is
> > zero.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

--
i.