Re: [PATCH v2 06/11] i2c: nomadik: support short xfer timeouts using waitqueue & hrtimer

From: Wolfram Sang
Date: Mon Mar 04 2024 - 06:38:07 EST



> > > - int timeout;
> > > + int timeout_usecs;
> >
> > I think 'unsigned' makes a lot of sense here. Maybe u32 even?
>
> Yes unsigned would make sense. unsigned int or u32, I wouldn't know
> which to pick.

It gets (later) fed by of_property_read_u32(), so I tend to suggest u32.
Sounds like least conversions then but please double check.

Attachment: signature.asc
Description: PGP signature