Re: [PATCH 2/4] arm64: dts: mediatek: mt8195: Add missing gce-client-reg to vpp/vdosys

[AngeloGioacchino Del Regno]

Il 01/03/24 15:39, Nícolas F. R. A. Prado ha scritto:
> On Fri, Mar 01, 2024 at 09:50:31AM +0100, AngeloGioacchino Del Regno wrote:
> > Il 29/02/24 20:44, Nícolas F. R. A. Prado ha scritto:
> > > Add the missing mediatek,gce-client-reg property to the vppsys and
> > > vdosys nodes to allow them to use the GCE. This prevents the "can't
> > > parse gce-client-reg property" error from being printed and should
> > > result in better performance.
> > >
> > > Fixes: 6aa5b46d1755 ("arm64: dts: mt8195: Add vdosys and vppsys clock nodes")
> > > Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>
> >
> > Can you please squash patches 2,3,4 in a single one?
> >
> > It doesn't make a lot of sense to have them separated in this case, only
> > generates commit noise for no practical reason imo.
> >
> > arm64: dts: mediatek: mt8195: Add missing gce-client-reg to vpp/vdo/mutex
>
> I split them like this so that each has its own fixes tag and can all be easily
> backported (as mentioned in the cover letter). That said, the commits fixed in 2
> and 3 both landed in v6.1-rc1, so they could be squashed and still easily
> backported. But the commit fixed in patch 4 only landed in v6.4-rc1, so if we
> squash them all together, the first two won't be backported to v6.1.
>
> Let me know how you want to proceed.

Oh, I'm sorry I didn't notice that. Ignore my previous comment then, I'll take
those for the next fixes round as-is.

Cheers,
Angelo