Re: [PATCH 2/4] arm64: dts: mediatek: mt7622: fix IR nodename

[AngeloGioacchino Del Regno]

Il 01/03/24 12:35, Rafał Miłecki ha scritto:
> From: Rafał Miłecki <rafal@xxxxxxxxxx>
>
> Fix following validation error:
> arch/arm64/boot/dts/mediatek/mt7622-rfb1.dtb: cir@10009000: $nodename:0: 'cir@10009000' does not match '^ir(-receiver)?(@[a-f0-9]+)?$'
>          from schema $id: http://devicetree.org/schemas/media/mediatek,mt7622-cir.yaml#
>
> Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx>

Is this an IR receiver, an IR transmitter or a xceiver?

While we're fixing that node name, we might as well increase readability of (and
somewhat implicitly document) this.

.. so, that might be...:

ir-receiver@xxxxx {
...

Cheers,
Angelo

> ---
>   arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> index 283fdf7d2d8b..7714775d1bd0 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> @@ -252,7 +252,7 @@ scpsys: power-controller@10006000 {
>   		clock-names = "hif_sel";
>   	};
>   
> -	cir: cir@10009000 {
> +	cir: ir@10009000 {
>   		compatible = "mediatek,mt7622-cir";
>   		reg = <0 0x10009000 0 0x1000>;
>   		interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_LOW>;