Re: [PATCH v2] Staging: pi433: Updated bitrate range from datasheet

[Aman Sharma]

Tbh this is my first patch and I don't have the hardware to test this. I 
thought updating the values from the datasheet directly might be a good 
idea as it would be the correct range. Please correct me if there is 
something that I missed / need to know.

On 2024-03-04 13:55, Dan Carpenter wrote:
> On Mon, Mar 04, 2024 at 11:23:40AM +0530, Aman Sharma wrote:
> > Updated bitrate range for FSK and OOK modulation from the RFM69 
> > Datasheet.
> > The values are mentioned in Section 2.3.2 of the datasheet.
>
> Have you tested these as well?  Sending untested patches is not
> necessarily against the rules, but it seems like maybe you have this
> hardware and can test it.  Could you please talk about what testing you
> did?
>
> > Signed-off-by: Aman Sharma<amansharma6122002@xxxxxxxxx>
>                             ^
> Missing space.

I'll fix this if I am allowed to submit a new patch.

> regards,
> dan carpenter