Re: [PATCH regression fix] misc: lis3lv02d_i2c: Fix regulators getting en-/dis-abled twice on suspend/resume

From: Greg Kroah-Hartman
Date: Mon Mar 04 2024 - 02:01:06 EST


On Fri, Mar 01, 2024 at 06:20:52AM +0100, Linux regression tracking (Thorsten Leemhuis) wrote:
> On 27.02.24 17:25, Linux regression tracking (Thorsten Leemhuis) wrote:
> > On 20.02.24 20:00, Hans de Goede wrote:
> >> When not configured for wakeup lis3lv02d_i2c_suspend() will call
> >> lis3lv02d_poweroff() even if the device has already been turned off
> >> by the runtime-suspend handler and if configured for wakeup and
> >> the device is runtime-suspended at this point then it is not turned
> >> back on to serve as a wakeup source.
> >>
> >> [...]
> >>
> >> Fixes: b1b9f7a49440 ("misc: lis3lv02d_i2c: Add missing setting of the reg_ctrl callback")
> >> Reported-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
> >> Closes: https://lore.kernel.org/regressions/5fc6da74-af0a-4aac-b4d5-a000b39a63a5@xxxxxxxxxxxxx/
> >> Cc: stable@xxxxxxxxxxxxxxx
> >> Cc: regressions@xxxxxxxxxxxxxxx
> >
> > Paul, did you maybe test this? I suppose Greg had no time to review this
> > yet due to all the CVE stuff and stable tree maintenance; but with a bit
> > of luck a "Tested-by" from your side might motivate him or somebody else
> > to look into this.
>
> Hmmm, Greg seems to be pretty busy with other stuff. Hans, is there
> maybe someone we can motivate into reviewing this to make it easier for
> Greg to pick this up and send it to Linus before -rc8/the final?
>
> Sure, it's "just" a warning fix, still would have been nice to get this
> into -rc7. But I guess time has already run out on that. :-/

Sorry for the delay, this ended up at the bottom of my pile. I'll pick
it up now...

greg k-h