Re: [PATCH v3 1/4] auxdisplay: Add 7-segment LED display driver

From: Yury Norov
Date: Sun Mar 03 2024 - 15:56:34 EST


On Sun, Mar 03, 2024 at 10:35:03PM +0200, Andy Shevchenko wrote:
> +Cc: Rasmus, Yury
>
> On Sun, Mar 3, 2024 at 9:58 PM Chris Packham
> <Chris.Packham@xxxxxxxxxxxxxxxxxxx> wrote:
> > On 2/03/24 07:18, Andy Shevchenko wrote:
>
> ...
>
> > >> + DECLARE_BITMAP(values, 8);
> > >> + bitmap_zero(values, 8);
> > > Why do you need this zeroing?
> > >
> > >> + bitmap_set_value8(values, map_to_seg7(&map->map.seg7, linedisp->buf[0]), 0);
>
> > Without the zeroing above GCC complains about use of a potentially
> > uninitialized variable here. I think because bitmap_set_value8() does &=
> > and |=.
>
> Hmm... Rasmus, Yury, do we have any ideas how to get rid of this redundancy?

DECLARE_BITMAP(values, 8) = { 0 };