Re: [syzbot] [lsm?] [integrity?] KMSAN: uninit-value in ima_add_template_entry

From: syzbot
Date: Sat Mar 02 2024 - 17:01:39 EST


syzbot has found a reproducer for the following issue on:

HEAD commit: 5ad3cb0ed525 Merge tag 'for-v6.8-rc2' of git://git.kernel...
git tree: upstream
console+strace: https://syzkaller.appspot.com/x/log.txt?x=15fdefac180000
kernel config: https://syzkaller.appspot.com/x/.config?x=80c7a82a572c0de3
dashboard link: https://syzkaller.appspot.com/bug?extid=7bc44a489f0ef0670bd5
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11917b26180000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1256096a180000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/a148235ac5b1/disk-5ad3cb0e.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/4b06f4d02ad6/vmlinux-5ad3cb0e.xz
kernel image: https://storage.googleapis.com/syzbot-assets/7fff06beed25/bzImage-5ad3cb0e.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/adece4ed9c9c/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+7bc44a489f0ef0670bd5@xxxxxxxxxxxxxxxxxxxxxxxxx

erofs: (device loop0): mounted with root inode @ nid 36.
=====================================================
BUG: KMSAN: uninit-value in ima_add_template_entry+0x52b/0x870 security/integrity/ima/ima_queue.c:172
ima_add_template_entry+0x52b/0x870 security/integrity/ima/ima_queue.c:172
ima_store_template security/integrity/ima/ima_api.c:122 [inline]
ima_store_measurement+0x371/0x8d0 security/integrity/ima/ima_api.c:376
process_measurement+0x2c6e/0x3ef0 security/integrity/ima/ima_main.c:367
ima_file_check+0xb3/0x100 security/integrity/ima/ima_main.c:557
do_open fs/namei.c:3647 [inline]
path_openat+0x4d09/0x5ad0 fs/namei.c:3802
do_filp_open+0x20d/0x590 fs/namei.c:3829
do_sys_openat2+0x1bf/0x2f0 fs/open.c:1404
do_sys_open fs/open.c:1419 [inline]
__do_sys_open fs/open.c:1427 [inline]
__se_sys_open fs/open.c:1423 [inline]
__x64_sys_open+0x275/0x2d0 fs/open.c:1423
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x63/0x6b

<Zero or more stacks not recorded to save memory>

Uninit was stored to memory at:
sha256_transform lib/crypto/sha256.c:117 [inline]
sha256_transform_blocks+0x2dbf/0x2e80 lib/crypto/sha256.c:127
lib_sha256_base_do_update include/crypto/sha256_base.h:63 [inline]
sha256_update+0x2fb/0x340 lib/crypto/sha256.c:136
crypto_sha256_update+0x37/0x60 crypto/sha256_generic.c:39
crypto_shash_update+0x75/0xa0 crypto/shash.c:70
ima_calc_file_hash_tfm security/integrity/ima/ima_crypto.c:496 [inline]
ima_calc_file_shash security/integrity/ima/ima_crypto.c:516 [inline]
ima_calc_file_hash+0x1816/0x3cc0 security/integrity/ima/ima_crypto.c:573
ima_collect_measurement+0x44d/0xdd0 security/integrity/ima/ima_api.c:290
process_measurement+0x2936/0x3ef0 security/integrity/ima/ima_main.c:359
ima_file_check+0xb3/0x100 security/integrity/ima/ima_main.c:557
do_open fs/namei.c:3647 [inline]
path_openat+0x4d09/0x5ad0 fs/namei.c:3802
do_filp_open+0x20d/0x590 fs/namei.c:3829
do_sys_openat2+0x1bf/0x2f0 fs/open.c:1404
do_sys_open fs/open.c:1419 [inline]
__do_sys_open fs/open.c:1427 [inline]
__se_sys_open fs/open.c:1423 [inline]
__x64_sys_open+0x275/0x2d0 fs/open.c:1423
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x63/0x6b

Uninit was stored to memory at:
sha256_transform lib/crypto/sha256.c:117 [inline]
sha256_transform_blocks+0x2dbf/0x2e80 lib/crypto/sha256.c:127
lib_sha256_base_do_update include/crypto/sha256_base.h:63 [inline]
sha256_update+0x2fb/0x340 lib/crypto/sha256.c:136
crypto_sha256_update+0x37/0x60 crypto/sha256_generic.c:39
crypto_shash_update+0x75/0xa0 crypto/shash.c:70
ima_calc_file_hash_tfm security/integrity/ima/ima_crypto.c:496 [inline]
ima_calc_file_shash security/integrity/ima/ima_crypto.c:516 [inline]
ima_calc_file_hash+0x1816/0x3cc0 security/integrity/ima/ima_crypto.c:573
ima_collect_measurement+0x44d/0xdd0 security/integrity/ima/ima_api.c:290
process_measurement+0x2936/0x3ef0 security/integrity/ima/ima_main.c:359
ima_file_check+0xb3/0x100 security/integrity/ima/ima_main.c:557
do_open fs/namei.c:3647 [inline]
path_openat+0x4d09/0x5ad0 fs/namei.c:3802
do_filp_open+0x20d/0x590 fs/namei.c:3829
do_sys_openat2+0x1bf/0x2f0 fs/open.c:1404
do_sys_open fs/open.c:1419 [inline]
__do_sys_open fs/open.c:1427 [inline]
__se_sys_open fs/open.c:1423 [inline]
__x64_sys_open+0x275/0x2d0 fs/open.c:1423
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x63/0x6b

Uninit was stored to memory at:
BLEND_OP lib/crypto/sha256.c:61 [inline]
sha256_transform lib/crypto/sha256.c:91 [inline]
sha256_transform_blocks+0xf33/0x2e80 lib/crypto/sha256.c:127
lib_sha256_base_do_update include/crypto/sha256_base.h:63 [inline]
sha256_update+0x2fb/0x340 lib/crypto/sha256.c:136
crypto_sha256_update+0x37/0x60 crypto/sha256_generic.c:39
crypto_shash_update+0x75/0xa0 crypto/shash.c:70
ima_calc_file_hash_tfm security/integrity/ima/ima_crypto.c:496 [inline]
ima_calc_file_shash security/integrity/ima/ima_crypto.c:516 [inline]
ima_calc_file_hash+0x1816/0x3cc0 security/integrity/ima/ima_crypto.c:573
ima_collect_measurement+0x44d/0xdd0 security/integrity/ima/ima_api.c:290
process_measurement+0x2936/0x3ef0 security/integrity/ima/ima_main.c:359
ima_file_check+0xb3/0x100 security/integrity/ima/ima_main.c:557
do_open fs/namei.c:3647 [inline]
path_openat+0x4d09/0x5ad0 fs/namei.c:3802
do_filp_open+0x20d/0x590 fs/namei.c:3829
do_sys_openat2+0x1bf/0x2f0 fs/open.c:1404
do_sys_open fs/open.c:1419 [inline]
__do_sys_open fs/open.c:1427 [inline]
__se_sys_open fs/open.c:1423 [inline]
__x64_sys_open+0x275/0x2d0 fs/open.c:1423
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x63/0x6b

Uninit was stored to memory at:
BLEND_OP lib/crypto/sha256.c:61 [inline]
sha256_transform lib/crypto/sha256.c:92 [inline]
sha256_transform_blocks+0xf7d/0x2e80 lib/crypto/sha256.c:127
lib_sha256_base_do_update include/crypto/sha256_base.h:63 [inline]
sha256_update+0x2fb/0x340 lib/crypto/sha256.c:136
crypto_sha256_update+0x37/0x60 crypto/sha256_generic.c:39
crypto_shash_update+0x75/0xa0 crypto/shash.c:70
ima_calc_file_hash_tfm security/integrity/ima/ima_crypto.c:496 [inline]
ima_calc_file_shash security/integrity/ima/ima_crypto.c:516 [inline]
ima_calc_file_hash+0x1816/0x3cc0 security/integrity/ima/ima_crypto.c:573
ima_collect_measurement+0x44d/0xdd0 security/integrity/ima/ima_api.c:290
process_measurement+0x2936/0x3ef0 security/integrity/ima/ima_main.c:359
ima_file_check+0xb3/0x100 security/integrity/ima/ima_main.c:557
do_open fs/namei.c:3647 [inline]
path_openat+0x4d09/0x5ad0 fs/namei.c:3802
do_filp_open+0x20d/0x590 fs/namei.c:3829
do_sys_openat2+0x1bf/0x2f0 fs/open.c:1404
do_sys_open fs/open.c:1419 [inline]
__do_sys_open fs/open.c:1427 [inline]
__se_sys_open fs/open.c:1423 [inline]
__x64_sys_open+0x275/0x2d0 fs/open.c:1423
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x63/0x6b

Uninit was stored to memory at:
BLEND_OP lib/crypto/sha256.c:61 [inline]
sha256_transform lib/crypto/sha256.c:93 [inline]
sha256_transform_blocks+0xfb5/0x2e80 lib/crypto/sha256.c:127
lib_sha256_base_do_update include/crypto/sha256_base.h:63 [inline]
sha256_update+0x2fb/0x340 lib/crypto/sha256.c:136
crypto_sha256_update+0x37/0x60 crypto/sha256_generic.c:39
crypto_shash_update+0x75/0xa0 crypto/shash.c:70
ima_calc_file_hash_tfm security/integrity/ima/ima_crypto.c:496 [inline]
ima_calc_file_shash security/integrity/ima/ima_crypto.c:516 [inline]
ima_calc_file_hash+0x1816/0x3cc0 security/integrity/ima/ima_crypto.c:573
ima_collect_measurement+0x44d/0xdd0 security/integrity/ima/ima_api.c:290
process_measurement+0x2936/0x3ef0 security/integrity/ima/ima_main.c:359
ima_file_check+0xb3/0x100 security/integrity/ima/ima_main.c:557
do_open fs/namei.c:3647 [inline]
path_openat+0x4d09/0x5ad0 fs/namei.c:3802
do_filp_open+0x20d/0x590 fs/namei.c:3829
do_sys_openat2+0x1bf/0x2f0 fs/open.c:1404
do_sys_open fs/open.c:1419 [inline]
__do_sys_open fs/open.c:1427 [inline]
__se_sys_open fs/open.c:1423 [inline]
__x64_sys_open+0x275/0x2d0 fs/open.c:1423
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x63/0x6b

Uninit was stored to memory at:
LOAD_OP lib/crypto/sha256.c:56 [inline]
sha256_transform lib/crypto/sha256.c:82 [inline]
sha256_transform_blocks+0x2c35/0x2e80 lib/crypto/sha256.c:127
lib_sha256_base_do_update include/crypto/sha256_base.h:63 [inline]
sha256_update+0x2fb/0x340 lib/crypto/sha256.c:136
crypto_sha256_update+0x37/0x60 crypto/sha256_generic.c:39
crypto_shash_update+0x75/0xa0 crypto/shash.c:70
ima_calc_file_hash_tfm security/integrity/ima/ima_crypto.c:496 [inline]
ima_calc_file_shash security/integrity/ima/ima_crypto.c:516 [inline]
ima_calc_file_hash+0x1816/0x3cc0 security/integrity/ima/ima_crypto.c:573
ima_collect_measurement+0x44d/0xdd0 security/integrity/ima/ima_api.c:290
process_measurement+0x2936/0x3ef0 security/integrity/ima/ima_main.c:359
ima_file_check+0xb3/0x100 security/integrity/ima/ima_main.c:557
do_open fs/namei.c:3647 [inline]
path_openat+0x4d09/0x5ad0 fs/namei.c:3802
do_filp_open+0x20d/0x590 fs/namei.c:3829
do_sys_openat2+0x1bf/0x2f0 fs/open.c:1404
do_sys_open fs/open.c:1419 [inline]
__do_sys_open fs/open.c:1427 [inline]
__se_sys_open fs/open.c:1423 [inline]
__x64_sys_open+0x275/0x2d0 fs/open.c:1423
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x63/0x6b

Uninit was stored to memory at:
memcpy_to_iter lib/iov_iter.c:65 [inline]
iterate_kvec include/linux/iov_iter.h:85 [inline]
iterate_and_advance2 include/linux/iov_iter.h:251 [inline]
iterate_and_advance include/linux/iov_iter.h:271 [inline]
_copy_to_iter+0x125a/0x2520 lib/iov_iter.c:186
copy_page_to_iter+0x419/0x870 lib/iov_iter.c:381
copy_folio_to_iter include/linux/uio.h:181 [inline]
filemap_read+0xbf4/0x14d0 mm/filemap.c:2654
generic_file_read_iter+0x136/0xad0 mm/filemap.c:2784
__kernel_read+0x724/0xce0 fs/read_write.c:434
integrity_kernel_read+0x77/0x90 security/integrity/iint.c:221
ima_calc_file_hash_tfm security/integrity/ima/ima_crypto.c:485 [inline]
ima_calc_file_shash security/integrity/ima/ima_crypto.c:516 [inline]
ima_calc_file_hash+0x1743/0x3cc0 security/integrity/ima/ima_crypto.c:573
ima_collect_measurement+0x44d/0xdd0 security/integrity/ima/ima_api.c:290
process_measurement+0x2936/0x3ef0 security/integrity/ima/ima_main.c:359
ima_file_check+0xb3/0x100 security/integrity/ima/ima_main.c:557
do_open fs/namei.c:3647 [inline]
path_openat+0x4d09/0x5ad0 fs/namei.c:3802
do_filp_open+0x20d/0x590 fs/namei.c:3829
do_sys_openat2+0x1bf/0x2f0 fs/open.c:1404
do_sys_open fs/open.c:1419 [inline]
__do_sys_open fs/open.c:1427 [inline]
__se_sys_open fs/open.c:1423 [inline]
__x64_sys_open+0x275/0x2d0 fs/open.c:1423
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x63/0x6b

Uninit was created at:
__alloc_pages+0x9a6/0xe00 mm/page_alloc.c:4590
alloc_pages_mpol+0x62b/0x9d0 mm/mempolicy.c:2133
alloc_pages mm/mempolicy.c:2204 [inline]
folio_alloc+0x1da/0x380 mm/mempolicy.c:2211
filemap_alloc_folio+0xa5/0x430 mm/filemap.c:975
page_cache_ra_unbounded+0x2cc/0x960 mm/readahead.c:247
do_page_cache_ra mm/readahead.c:299 [inline]
page_cache_ra_order+0xe31/0xee0 mm/readahead.c:544
ondemand_readahead+0x157d/0x1750 mm/readahead.c:666
page_cache_sync_ra+0x724/0x760 mm/readahead.c:693
page_cache_sync_readahead include/linux/pagemap.h:1300 [inline]
filemap_get_pages+0x4c4/0x2bd0 mm/filemap.c:2498
filemap_read+0x59e/0x14d0 mm/filemap.c:2594
generic_file_read_iter+0x136/0xad0 mm/filemap.c:2784
__kernel_read+0x724/0xce0 fs/read_write.c:434
integrity_kernel_read+0x77/0x90 security/integrity/iint.c:221
ima_calc_file_hash_tfm security/integrity/ima/ima_crypto.c:485 [inline]
ima_calc_file_shash security/integrity/ima/ima_crypto.c:516 [inline]
ima_calc_file_hash+0x1743/0x3cc0 security/integrity/ima/ima_crypto.c:573
ima_collect_measurement+0x44d/0xdd0 security/integrity/ima/ima_api.c:290
process_measurement+0x2936/0x3ef0 security/integrity/ima/ima_main.c:359
ima_file_check+0xb3/0x100 security/integrity/ima/ima_main.c:557
do_open fs/namei.c:3647 [inline]
path_openat+0x4d09/0x5ad0 fs/namei.c:3802
do_filp_open+0x20d/0x590 fs/namei.c:3829
do_sys_openat2+0x1bf/0x2f0 fs/open.c:1404
do_sys_open fs/open.c:1419 [inline]
__do_sys_open fs/open.c:1427 [inline]
__se_sys_open fs/open.c:1423 [inline]
__x64_sys_open+0x275/0x2d0 fs/open.c:1423
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x63/0x6b

CPU: 0 PID: 5012 Comm: syz-executor394 Not tainted 6.8.0-rc6-syzkaller-00238-g5ad3cb0ed525 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/25/2024
=====================================================


---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.