Re: [PATCH] serial: 8250_dw: Do not reclock if already at correct rate

From: Greg Kroah-Hartman
Date: Sat Mar 02 2024 - 16:02:12 EST


On Thu, Feb 22, 2024 at 11:26:34AM -0800, Peter Collingbourne wrote:
> When userspace opens the console, we call set_termios() passing a
> termios with the console's configured baud rate. Currently this causes
> dw8250_set_termios() to disable and then re-enable the UART clock at
> the same frequency as it was originally. This can cause corruption
> of any concurrent console output. Fix it by skipping the reclocking
> if we are already at the correct rate.
>
> Signed-off-by: Peter Collingbourne <pcc@xxxxxxxxxx>
> Link: https://linux-review.googlesource.com/id/I2e3761d239cbf29ed41412e5338f30bffe1efc70

Again, why the link? What does that help with? Our tools add a Link:
tag to this public email thread, not a google gerrit instance.

thanks,

greg k-h