Re: [PATCH v2 2/2] dt-bindings: dma: fsl-edma: allow 'power-domains' property

From: Krzysztof Kozlowski
Date: Sat Mar 02 2024 - 08:59:54 EST


On 01/03/2024 22:45, Frank Li wrote:
> Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need
> it.
>
> Fixed below DTB_CHECK warning:
> dma-controller@599f0000: Unevaluated properties are not allowed ('power-domains' was unexpected)
>
> Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> ---
>
> Notes:
> Change from v1 to v2
> - using maxitem: 64. Each channel have one power domain. Max 64 dmachannel.
> - add power-domains to 'required' when compatible string is fsl,imx8qm-adma
> or fsl,imx8qm-edma
>
> .../devicetree/bindings/dma/fsl,edma.yaml | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> index cf0aa8e6b9ec3..76c1716b8b95c 100644
> --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> @@ -59,6 +59,10 @@ properties:
> minItems: 1
> maxItems: 2
>
> + power-domains:
> + minItems: 1
> + maxItems: 64

Hm, this is odd. Blocks do not belong to almost infinite number of power
domains.

Best regards,
Krzysztof