Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

[Zi Yan]

On 1 Mar 2024, at 9:27, Mark Brown wrote:

> On Fri, Mar 01, 2024 at 02:18:16PM +0000, Ryan Roberts wrote:
>
>> Although I agree it might be a tall order create and mount an XFS fs in
>> run_vmtests.sh. Perhaps it might be good enough to add an optional param to the
>> test to pass a path when running the test manually, and if that's not provided,
>> just try to create a temp file in the current dir and skip if its not the right
>> sort of fs?
>
> Yeah, if it needs to be a specific kind of on disk filesystem then that
> needs a lot more integration with CI systems (a lot of them run entirely
> from nfsroot by default!).  Being able to specify the location via an
> environment variable would also be good, it could fall back to the
> current directory if one isn't set up.
Hi Mark,

I have changed the test[1] to:
1. accept XFS dev as an input,
2. mount XFS on a temp folder,
3. skip the test instead of fail if no XFS is mounted.

Let me know if the change looks good. Thanks.

[1] https://lore.kernel.org/linux-mm/A111EB95-0AF5-4715-82A4-70B8AD900A93@xxxxxxxxxx/T/#u

--
Best Regards,
Yan, Zi

Attachment: signature.asc
Description: OpenPGP digital signature