Re: [PATCH] perf vendor events amd: Fix Zen 4 cache latency events

[Ian Rogers]

On Fri, Mar 1, 2024 at 12:44 AM Sandipan Das <sandipan.das@xxxxxxx> wrote:
>
> L3PMCx0AC and L3PMCx0AD, used in l3_xi_sampled_latency* events, have a
> quirk that requires them to be programmed with SliceId set to 0x3.
> Without this, the events do not count at all and affects dependent
> metrics such as l3_read_miss_latency.
>
> If ThreadMask is not specified, the amd-uncore driver internally sets
> ThreadMask to 0x3, EnAllCores to 0x1 and EnAllSlices to 0x1 but does
> not set SliceId. Since SliceId must also be set to 0x3 in this case,
> specify all the other fields explicitly.
>
> E.g.
>
>   $ sudo perf stat -e l3_xi_sampled_latency.all,l3_xi_sampled_latency_requests.all -a sleep 1
>
> Before:
>
>    Performance counter stats for 'system wide':
>
>                    0      l3_xi_sampled_latency.all
>                    0      l3_xi_sampled_latency_requests.all
>
>          1.005155399 seconds time elapsed
>
> After:
>
>    Performance counter stats for 'system wide':
>
>              921,446      l3_xi_sampled_latency.all
>               54,210      l3_xi_sampled_latency_requests.all
>
>          1.005664472 seconds time elapsed
>
> Fixes: 5b2ca349c313 ("perf vendor events amd: Add Zen 4 uncore events")
> Signed-off-by: Sandipan Das <sandipan.das@xxxxxxx>

Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>

Thanks,
Ian