Re: [PATCH v2 9/9] drm/panel: truly-nt35597: Don't log an error when DSI host can't be found

[AngeloGioacchino Del Regno]

Il 01/03/24 07:30, Laurent Pinchart ha scritto:
> Hi Nícolas,
>
> Thank you for the patch.
>
> On Thu, Feb 29, 2024 at 07:12:15PM -0500, Nícolas F. R. A. Prado wrote:
> > Given that failing to find a DSI host causes the driver to defer probe,
> > make use of dev_err_probe() to log the reason. This makes the defer
> > probe reason available and avoids alerting userspace about something
> > that is not necessarily an error.
> >
> > Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>
> > ---
> >   drivers/gpu/drm/panel/panel-truly-nt35597.c | 6 ++----
> >   1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-truly-nt35597.c b/drivers/gpu/drm/panel/panel-truly-nt35597.c
> > index b73448cf349d..d447db912a61 100644
> > --- a/drivers/gpu/drm/panel/panel-truly-nt35597.c
> > +++ b/drivers/gpu/drm/panel/panel-truly-nt35597.c
> > @@ -550,10 +550,8 @@ static int truly_nt35597_probe(struct mipi_dsi_device *dsi)
> >   
> >   	dsi1_host = of_find_mipi_dsi_host_by_node(dsi1);
> >   	of_node_put(dsi1);
> > -	if (!dsi1_host) {
> > -		dev_err(dev, "failed to find dsi host\n");
> > -		return -EPROBE_DEFER;
> > -	}
> > +	if (!dsi1_host)
> > +		return dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n");
>
> 		return dev_err_probe(dev, -EPROBE_DEFER,
> 				     "failed to find dsi host\n");
>
> With this addressed,

I disagree. That's 87 columns, and the 80-col rule is long gone.

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>
> >   
> >   	/* register the second DSI device */
> >   	dsi1_device = mipi_dsi_device_register_full(dsi1_host, &info);