Re: [PATCH 2/6] sparc32: Fix build with trapbase

From: Randy Dunlap
Date: Fri Feb 23 2024 - 19:29:15 EST




On 2/23/24 11:36, Sam Ravnborg via B4 Relay wrote:
> From: Sam Ravnborg <sam@xxxxxxxxxxxx>
>
> Fix the following build errors:
> irq_32.c:258:7: error: array subscript [16, 79] is outside array bounds of 'struct tt_entry[1]
> irq_32.c:271:14: error: assignment to 'struct tt_entry *' from incompatible pointer type 'struct tt_entry (*)[]
>
> trapbase is a pointer to an array of tt_entry, but the code declared it
> as a pointer so the compiler see a single entry and not an array.
> Fix this by modifyinf the declaration to be an array, and modify all
> users to take the address of the first member.
>
> Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Andreas Larsson <andreas@xxxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested

Thanks.

> ---
> arch/sparc/kernel/irq_32.c | 6 +++---
> arch/sparc/kernel/kernel.h | 8 ++++----
> arch/sparc/kernel/kgdb_32.c | 4 ++--
> arch/sparc/kernel/leon_smp.c | 6 +++---
> arch/sparc/kernel/setup_32.c | 4 ++--
> 5 files changed, 14 insertions(+), 14 deletions(-)
>


--
#Randy