Re: [PATCH v3 1/5] usb: dwc3-am62: call of_platform_depopulate in .remove()

[Thinh Nguyen]

On Wed, Feb 14, 2024, Roger Quadros wrote:
> We called of_platform_populate() in .probe() so call the
> cleanup function of_platform_depopulate() in .remove().
> 
> Get rid of the now unnnecessary dwc3_ti_remove_core().
> 
> Signed-off-by: Roger Quadros <rogerq@xxxxxxxxxx>
> ---
> Changelog:
> 
> v3: no change
> v2: no change
> 	https://urldefense.com/v3/__https://lore.kernel.org/all/20240205141221.56076-2-rogerq@xxxxxxxxxx/__;!!A4F2R9G_pg!f-317oDBUen4tQjM4Kk_1bBkD4OrvVVyd7XvIKjotuQlxsQVXxZoq-Q6SZIV_X7W2nFqfsAuwTrMhPV3Hreq$ 
> v1: https://urldefense.com/v3/__https://lore.kernel.org/all/20240201121220.5523-2-rogerq@xxxxxxxxxx/__;!!A4F2R9G_pg!f-317oDBUen4tQjM4Kk_1bBkD4OrvVVyd7XvIKjotuQlxsQVXxZoq-Q6SZIV_X7W2nFqfsAuwTrMhLhI0BZr$ 
> ---
>  drivers/usb/dwc3/dwc3-am62.c | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
> 
> diff --git a/drivers/usb/dwc3/dwc3-am62.c b/drivers/usb/dwc3/dwc3-am62.c
> index 90a587bc29b7..1bfc9e67614f 100644
> --- a/drivers/usb/dwc3/dwc3-am62.c
> +++ b/drivers/usb/dwc3/dwc3-am62.c
> @@ -267,21 +267,13 @@ static int dwc3_ti_probe(struct platform_device *pdev)
>  	return ret;
>  }
>  
> -static int dwc3_ti_remove_core(struct device *dev, void *c)
> -{
> -	struct platform_device *pdev = to_platform_device(dev);
> -
> -	platform_device_unregister(pdev);
> -	return 0;
> -}
> -
>  static void dwc3_ti_remove(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
>  	struct dwc3_am62 *am62 = platform_get_drvdata(pdev);
>  	u32 reg;
>  
> -	device_for_each_child(dev, NULL, dwc3_ti_remove_core);
> +	of_platform_depopulate(dev);
>  
>  	/* Clear mode valid bit */
>  	reg = dwc3_ti_readl(am62, USBSS_MODE_CONTROL);
> 
> -- 
> 2.34.1
> 

Acked-by: Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx>

Thanks,
Thinh