Re: [PATCH v2] clkdev: Update clkdev id usage to allow for longer names

[Russell King (Oracle)]

On Fri, Feb 23, 2024 at 08:32:27PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 23, 2024 at 06:22:13PM +0000, Ruhl, Michael J wrote:
> > >From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > >Sent: Friday, February 23, 2024 12:43 PM
> > >On Fri, Feb 23, 2024 at 11:35:16AM -0500, Michael J. Ruhl wrote:
> 
> ...
> 
> > I will remove.
> 
> Not remove, but move to the comments/changelog (after '---' line)
> 
> > I see your script automatically does a cover page...will use that format int
> > the future.
> 
> Only if there are more than a single patch.
> 
> ...
> 
> > >[1]: https://github.com/andy-shev/home-bin-
> > >tools/blob/master/ge2maintainer.sh
> > 
> > Using your script I got:
> > 
> > To: "Michael J. Ruhl" <michael.j.ruhl@xxxxxxxxx>,
> >         linux-arm-kernel@xxxxxxxxxxxxxxxxxxx,
> >         linux-kernel@xxxxxxxxxxxxxxx
> > Cc: Russell King <linux@xxxxxxxxxxxxxxx>
> > 
> > My list (using get_maintainers.pl) is:
> > 
> > linux@xxxxxxxxxxxxxxx
> > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > linux-kernel@xxxxxxxxxxxxxxx
> > 
> > They appear to be the same....
> 
> Ah, the Russel's email looked like a mailing list, that what confused me.

Joe, I think you know that I'll pick up on your mis-spelling of my
name... and I take that as an implicit right to call you something
other than your proper name. :D

Secondly, because the Cc contained my name, I fail to see how you can
confuse that with a mailing list. Maybe your script that you mentioned
strips the names from the email addresses, thereby adding to your
confusion - and maybe that isn't such a good idea after all? I'm not
the only one who uses linux@... There are six people in total listed in
MAINTAINERS who have a linux@... email address there.

> > I don't have the plain text part on Russel's email (linxu@xxxxxxxxxxxxxxx)... Is that what is missing?
> 
> Yes :-)
> But my script also uses a heuristics (which is not visible here) to add active
> developers of the code in question based on the git history.

The developers in question for this part of the code is me and not the
CCF. Therefore, what has been done by the patch author is reasonable
and no special scripts are necessary.

While my main git server is offline, I'm happy for the CCF folk
to pick this up, so:

Reviewed-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>

Michael, please resubmit with my r-b line above, and include the CCF
folk in that posting:

Michael Turquette <mturquette@xxxxxxxxxxxx>
Stephen Boyd <sboyd@xxxxxxxxxx>
linux-clk@xxxxxxxxxxxxxxx

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!