Re: [PATCH RFC bpf-next v3 00/16] sleepable bpf_timer (was: allow HID-BPF to do device IOs)

From: Benjamin Tissoires
Date: Fri Feb 23 2024 - 14:43:22 EST


Hi,

On Feb 23 2024, Eduard Zingerman wrote:
> On Wed, 2024-02-21 at 17:25 +0100, Benjamin Tissoires wrote:
> > [Partly a RFC/formal submission: there are still FIXMEs in the code]
> > [Also using bpf-next as the base tree for HID changes as there will
> > be conflicting changes otherwise, so I'm personaly fine for the HID
> > commits to go through bpf-next]
>
> [...]
>
> Could you please also add verifier selftests, e.g. extend
> tools/testing/selftests/bpf/progs/timer.c (bpf side)
> tools/testing/selftests/bpf/prog_tests/timer.c (userspace side triggering
> bpf side)
> Negative tests could be added in
> tools/testing/selftests/bpf/progs/timer_failure.c
>
> Please let me know if you need any help setting up local BPF test
> environment, I have a short writeup on how to set it up in chroot.

Thanks a lot for your review (and Alexei's). I was actually off today
and will be off next Monday too, but I'll work on those tests next week.

Cheers,
Benjamin