RE: [PATCH v2] clkdev: Update clkdev id usage to allow for longer names

[Ruhl, Michael J]

>-----Original Message-----
>From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>Sent: Friday, February 23, 2024 12:43 PM
>To: Ruhl, Michael J <michael.j.ruhl@xxxxxxxxx>
>Cc: linux@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
>kernel@xxxxxxxxxxxxxxx
>Subject: Re: [PATCH v2] clkdev: Update clkdev id usage to allow for longer
>names
>
>On Fri, Feb 23, 2024 at 11:35:16AM -0500, Michael J. Ruhl wrote:
>> clkdev DEV ID information is limited to an array of 20 bytes
>> (MAX_DEV_ID).  It is possible that the ID could be longer than
>> that.  If so, the lookup will fail because the "real ID" will
>> not match the copied value.
>>
>> For instance, generating a device name for the I2C Designware
>> module using the PCI ID can result in a name of:
>>
>> i2c_designware.39424
>>
>> clkdev_create() will store:
>>
>> i2c_designware.3942
>>
>> The stored name is one off and will not match correctly during probe.
>>
>> Increase the size of the ID to allow for a longer name.
>
>> v2: Removed CON_ID update and added example to commit
>
>Usually we put changelog out of the commit messages...

Yeah, usually put it in the cover letter.  I will remove. I see your script automatically
does a cover page...will use that format int the future.

>> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@xxxxxxxxx>
>> ---
>
>...somewhere here.

Ok.    Will keep for future reference.

>Also just noticed that you forgot CCF maintainers to be included.
>I'm suggesting to use my script [1] which harvests more or less
>adequate list of people and mailing lists to Cc email to.
>
>[1]: https://github.com/andy-shev/home-bin-
>tools/blob/master/ge2maintainer.sh

Using your script I got:

To: "Michael J. Ruhl" <michael.j.ruhl@xxxxxxxxx>,
        linux-arm-kernel@xxxxxxxxxxxxxxxxxxx,
        linux-kernel@xxxxxxxxxxxxxxx
Cc: Russell King <linux@xxxxxxxxxxxxxxx>

My list (using get_maintainers.pl) is:

linux@xxxxxxxxxxxxxxx
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
linux-kernel@xxxxxxxxxxxxxxx

They appear to be the same....

I don't have the plain text part on Russel's email (linxu@xxxxxxxxxxxxxxx).. Is that what is missing?

Not sure what CCF is?

M

>
>--
>With Best Regards,
>Andy Shevchenko
>