Re: [PATCH] clkdev: Update clkdev id usage to allow for longer names

From: Andy Shevchenko
Date: Fri Feb 23 2024 - 10:48:32 EST


On Fri, Feb 23, 2024 at 09:18:14AM -0500, Michael J. Ruhl wrote:
> clkdev ID information is limited to arrays of 20 and 16 bytes
> (MAX_DEV_ID/MAX_CON_ID). It is possible that the IDs could be
> longer that. If so, the lookup will fail because the "real ID"
> will not match the copied value.

Perhaps you need to add a real example.

> Increase the size of the IDs to allow for longer names.

..

> -#define MAX_DEV_ID 20
> -#define MAX_CON_ID 16
> +#define MAX_DEV_ID 32
> +#define MAX_CON_ID 32

Do we need to alter both?

--
With Best Regards,
Andy Shevchenko