Re: [for-next][PATCH 06/13] NFSD: Fix nfsd_clid_class use of __string_len() macro

[Steven Rostedt]

On Fri, 23 Feb 2024 09:36:14 -0500
Jeff Layton <jlayton@xxxxxxxxxx> wrote:

> On Fri, 2024-02-23 at 09:18 -0500, Steven Rostedt wrote:
> > From: "Steven Rostedt (Google)" <rostedt@xxxxxxxxxxx>
> > 
> > I'm working on restructuring the __string* macros so that it doesn't need
> > to recalculate the string twice. That is, it will save it off when
> > processing __string() and the __assign_str() will not need to do the work
> > again as it currently does.
> > 
> > Currently __string_len(item, src, len) doesn't actually use "src", but my
> > changes will require src to be correct as that is where the __assign_str()
> > will get its value from.
> > 
> > The event class nfsd_clid_class has:
> > 
> >   __string_len(name, name, clp->cl_name.len)
> > 
> > But the second "name" does not exist and causes my changes to fail to
> > build. That second parameter should be: clp->cl_name.data.
> > 
> > Link: https://lore.kernel.org/linux-trace-kernel/20240222122828.3d8d213c@xxxxxxxxxxxxxxxxxx
> > 

> 
> Acked-by: Jeff Layton <jlayton@xxxxxxxxxx>

Thanks!

-- Steve