Re: [PATCH v2 01/11] KVM: SEV: fix compat ABI for KVM_MEMORY_ENCRYPT_OP

From: Paolo Bonzini
Date: Fri Feb 23 2024 - 10:05:12 EST


On 2/23/24 15:20, Sean Christopherson wrote:
On Fri, Feb 23, 2024, Paolo Bonzini wrote:
The data structs for KVM_MEMORY_ENCRYPT_OP have different sizes for 32- and 64-bit
kernels, but they do not make any attempt to convert from one ABI to the other.
Fix this by adding the appropriate padding.
Maybe call out that SEV+ is 64-bit only, so this doesn't matter in practice? Or
does this affect .compat_ioctl()?

Yes, .compat_ioctl() is what I had in mind - but that means I have to change "32- and 64-bit kernels" to "... userspace".

Paolo