Re: [PATCH] gpio: sim: don't fiddle with GPIOLIB private members

From: Andy Shevchenko
Date: Fri Feb 23 2024 - 09:55:41 EST


On Thu, Feb 22, 2024 at 05:01:04PM -0800, Saravana Kannan wrote:
> On Wed, Feb 21, 2024 at 4:59 AM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > On Tue, Feb 20, 2024 at 05:46:27PM -0800, Saravana Kannan wrote:

..

> > Is there any _good_ documentation for devlinks and all that fields in the
> > struct fwnode? Why should we use that without any understanding of the
> > purposes of that field. We, as device property developers, hadn't introduced
> > that field and never required it. It's an alien to device properties APIs.
>
> If I add some inline documentation for these fields, will you be more
> open to letting people use this as a way to look up devices? I'm happy
> to do that for you.

I consider documentation patches to be always welcome. But it doesn't mean
we allow to use that fields in device property APIs without a very good
justification.

--
With Best Regards,
Andy Shevchenko