Re: [PATCH 1/2] kallsyms: get rid of code for absolute kallsyms

[Masahiro Yamada]

On Thu, Feb 22, 2024 at 5:27 AM Jann Horn <jannh@xxxxxxxxxx> wrote:
>
> To compile code for absolute kallsyms, you had to turn off
> KALLSYMS_BASE_RELATIVE. I think based on the way it was declared in
> Kconfig (without a string after "bool"), it wasn't even possible to
> select it.
>
> Get rid of this config option, as preparation for some kallsyms
> optimizations that would otherwise be infeasible.
>
> Signed-off-by: Jann Horn <jannh@xxxxxxxxxx>


The code is correct.
Based on Arnd's feedback, could you rephrase the commit description?

When 2213e9a66bb87d83 was applied, IA64 and (TILE && 64BIT)
opted out of KALLSYMS_BASE_RELATIVE.
Now, both architectures are gone.





In the commit description, for instance, you can say:

  Commit cf8e8658100d ("arch: Remove Itanium (IA-64) architecture")
  removed the last use for the combination of KALLSYMS=y and
  KALLSYMS_BASE_RELATIVE=n.






--
Best Regards
Masahiro Yamada