Re: [PATCH v4 0/5] Fix double allocation in swiotlb_alloc()

From: Nicolin Chen
Date: Fri Feb 23 2024 - 06:35:31 EST


On Wed, Feb 21, 2024 at 11:34:59AM +0000, Will Deacon wrote:
> Hi again, folks,
>
> This is version four of the patches which I previously posted at:
>
> v1: https://lore.kernel.org/r/20240126151956.10014-1-will@xxxxxxxxxx
> v2: https://lore.kernel.org/r/20240131122543.14791-1-will@xxxxxxxxxx
> v3: https://lore.kernel.org/r/20240205190127.20685-1-will@xxxxxxxxxx
>
> Thanks to Petr for his Reviewed-by tag on the first three.
>
> Changes since v3 include:
>
> - Use umax() instead of max() to fix a build warning if the first
> patch is applied to older kernels which warn on signedness
> mismatches.
>
> - Add two new patches to the end of the series to resolve some
> additional issues with NVME and 64KiB pages, reported by Nicolin.
> I've added them to this series, as the first three patches make it
> easier to fix this problem in the SWIOTLB code.
>
> - Add Reviewed-by tags from Petr
>
> Cheers,
>
> Will
>
> Cc: iommu@xxxxxxxxxxxxxxx
> Cc: Christoph Hellwig <hch@xxxxxx>
> Cc: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> Cc: Robin Murphy <robin.murphy@xxxxxxx>
> Cc: Petr Tesarik <petr.tesarik1@xxxxxxxxxxxxxxxxxxx>
> Cc: Dexuan Cui <decui@xxxxxxxxxxxxx>
> Cc: Nicolin Chen <nicolinc@xxxxxxxxxx>

This fixes the bug with NVME on arm64/SMMU when PAGE_SIZE=64KiB.

Tested-by: Nicolin Chen <nicolinc@xxxxxxxxxx>

Thanks!