Re: [PATCH net-next 1/2] netdev-genl: Add ifname for queue and NAPI APIs
From: Dan Carpenter
Date: Fri Feb 23 2024 - 06:21:47 EST
Hi Joe,
kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/Joe-Damato/netdev-genl-Add-ifname-for-queue-and-NAPI-APIs/20240222-000134
base: net-next/main
patch link: https://lore.kernel.org/r/1708531057-67392-2-git-send-email-jdamato%40fastly.com
patch subject: [PATCH net-next 1/2] netdev-genl: Add ifname for queue and NAPI APIs
config: i386-randconfig-141-20240222 (https://download.01.org/0day-ci/archive/20240223/202402231851.2NeORqwi-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
| Closes: https://lore.kernel.org/r/202402231851.2NeORqwi-lkp@xxxxxxxxx/
New smatch warnings:
net/core/netdev-genl.c:388 netdev_nl_queue_get_doit() error: uninitialized symbol 'ifname'.
vim +/ifname +388 net/core/netdev-genl.c
bc877956272f05 Amritha Nambiar 2023-12-01 371 int netdev_nl_queue_get_doit(struct sk_buff *skb, struct genl_info *info)
bc877956272f05 Amritha Nambiar 2023-12-01 372 {
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 373 u32 q_id, q_type, ifindex;
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 374 struct net_device *netdev;
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 375 struct sk_buff *rsp;
f340b224321fa6 Joe Damato 2024-02-21 376 char *ifname;
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 377 int err;
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 378
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 379 if (GENL_REQ_ATTR_CHECK(info, NETDEV_A_QUEUE_ID) ||
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 380 GENL_REQ_ATTR_CHECK(info, NETDEV_A_QUEUE_TYPE) ||
f340b224321fa6 Joe Damato 2024-02-21 381 GENL_REQ_ATTR_CHECK(info, NETDEV_A_QUEUE_IFINDEX) ||
f340b224321fa6 Joe Damato 2024-02-21 382 GENL_REQ_ATTR_CHECK(info, NETDEV_A_QUEUE_IFNAME))
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 383 return -EINVAL;
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 384
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 385 q_id = nla_get_u32(info->attrs[NETDEV_A_QUEUE_ID]);
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 386 q_type = nla_get_u32(info->attrs[NETDEV_A_QUEUE_TYPE]);
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 387 ifindex = nla_get_u32(info->attrs[NETDEV_A_QUEUE_IFINDEX]);
f340b224321fa6 Joe Damato 2024-02-21 @388 nla_strscpy(ifname, info->attrs[NETDEV_A_QUEUE_IFNAME], IFNAMSIZ);
^^^^^^
missing initialization
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 389
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 390 rsp = genlmsg_new(GENLMSG_DEFAULT_SIZE, GFP_KERNEL);
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 391 if (!rsp)
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 392 return -ENOMEM;
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 393
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 394 rtnl_lock();
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 395
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 396 netdev = __dev_get_by_index(genl_info_net(info), ifindex);
f340b224321fa6 Joe Damato 2024-02-21 397
f340b224321fa6 Joe Damato 2024-02-21 398 if (strcmp(netdev->name, ifname)) {
f340b224321fa6 Joe Damato 2024-02-21 399 err = -ENODEV;
f340b224321fa6 Joe Damato 2024-02-21 400 } else {
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 401 if (netdev)
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 402 err = netdev_nl_queue_fill(rsp, netdev, q_id, q_type, info);
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 403 else
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 404 err = -ENODEV;
f340b224321fa6 Joe Damato 2024-02-21 405 }
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 406
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 407 rtnl_unlock();
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 408
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 409 if (err)
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 410 goto err_free_msg;
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 411
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 412 return genlmsg_reply(rsp, info);
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 413
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 414 err_free_msg:
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 415 nlmsg_free(rsp);
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 416 return err;
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 417 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki