Re: [PATCH v2 1/4] leds: rgb: leds-group-multicolor: allow leds to stay on in suspend

From: Lee Jones
Date: Fri Feb 23 2024 - 05:28:28 EST


On Thu, 22 Feb 2024, Pavel Machek wrote:

> Hi!
>
> > If none of the managed leds enable LED_CORE_SUSPENDRESUME, then we
> > shouldn't need to set it here. This makes it possible to use multicolor
> > groups with gpio leds that enable retain-state-suspended in the device
> > tree.
> >
> > Signed-off-by: Aren Moynihan <aren@xxxxxxxxxxxxxxxxx>
>
> Thanks for the series.
>
> Acked-by: Pavel Machek <pavel@xxxxxx>
>
> Note this will change userland API and maybe break the LED for code
> expecting old setup and hardcoding paths. I guess we should not
> backport this to stable. But we should do this, because it is really
> one LED and not three.

Thanks Pavel.

Is this tied to the other patches in the set?

Will thing break if this is applied on its own?

--
Lee Jones [李琼斯]