Re: [PATCH v2 2/2] gpio: sim: use for_each_hwgpio()

From: Bartosz Golaszewski
Date: Fri Feb 23 2024 - 03:59:32 EST


On Thu, Feb 22, 2024 at 11:25 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>
> Display debugfs information about all simulated GPIOs, not only the
> requested ones.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> ---
> drivers/gpio/gpio-sim.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
> index c4106e37e6db..88fc3712811c 100644
> --- a/drivers/gpio/gpio-sim.c
> +++ b/drivers/gpio/gpio-sim.c
> @@ -234,10 +234,10 @@ static void gpio_sim_dbg_show(struct seq_file *seq, struct gpio_chip *gc)
>
> guard(mutex)(&chip->lock);
>
> - for_each_requested_gpio(gc, i, label)
> + for_each_hwgpio(gc, i, label)
> seq_printf(seq, " gpio-%-3d (%s) %s,%s\n",
> gc->base + i,
> - label,
> + label ?: "<unused>",
> test_bit(i, chip->direction_map) ? "input" :
> test_bit(i, chip->value_map) ? "output-high" :
> "output-low",
> --
> 2.40.1
>

Patch applied.

Bart