Re: [PATCH 1/3] platform/x86/intel/vsec: Remove nuisance message

[Kuppuswamy Sathyanarayanan]

On 2/21/24 1:12 PM, David E. Box wrote:
> intel_vsec_walk_header() is used to configure features from devices that
> don't provide a PCI VSEC or DVSEC structure. Some of these features may
> be unsupported and fail to load. Ignore them silently as we do for
> unsupported features described by VSEC/DVSEC.
>
> Signed-off-by: David E. Box <david.e.box@xxxxxxxxxxxxxxx>
> ---

Change looks fine to me.

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>

>  drivers/platform/x86/intel/vsec.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel/vsec.c
> index 778eb0aa3479..0fdfaf3a4f5c 100644
> --- a/drivers/platform/x86/intel/vsec.c
> +++ b/drivers/platform/x86/intel/vsec.c
> @@ -236,10 +236,7 @@ static bool intel_vsec_walk_header(struct pci_dev *pdev,
>  
>  	for ( ; *header; header++) {
>  		ret = intel_vsec_add_dev(pdev, *header, info);
> -		if (ret)
> -			dev_info(&pdev->dev, "Could not add device for VSEC id %d\n",
> -				 (*header)->id);
> -		else
> +		if (!ret)
>  			have_devices = true;
>  	}
>  
>
> base-commit: 841c35169323cd833294798e58b9bf63fa4fa1de

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer