Re: [PATCH v8 10/10] KVM: selftests: Add a basic SEV smoke test

From: Sean Christopherson
Date: Thu Feb 22 2024 - 17:42:25 EST


On Tue, Feb 06, 2024, Sean Christopherson wrote:
> On Fri, Feb 02, 2024, Sean Christopherson wrote:
> > +int main(int argc, char *argv[])
> > +{
> > + TEST_REQUIRE(is_kvm_sev_supported());
>
> This also needs
>
> TEST_REQUIRE(kvm_cpu_has(X86_FEATURE_SEV));
>
> to handle the case where the platform supports SEV, i.e. /dev/sev exists, but
> KVM doesn't support SEV, e.g. if TDP is disabled, if SEV was explicitly disabled
> via module param, etc.

Thinking more about this, I think we should simply delete is_kvm_sev_supported().
(a) it obviously doesn't query _KVM_ support, and (b) if KVM says SEV is supported,
then it darn well actually be supported.