Re: [PATCH net-next v2 2/4] net: macb: Add ARP support to WOL
From: Andrew Lunn
Date: Thu Feb 22 2024 - 14:33:30 EST
> u32 wol;
> + u32 wolopts;
> + wol->supported |= (bp->wol & MACB_WOL_HAS_MAGIC_PACKET) ? WAKE_MAGIC : 0;
> + wol->supported |= (bp->wol & MACB_WOL_HAS_ARP_PACKET) ? WAKE_ARP : 0;
> + if (bp->caps & MACB_CAPS_WOL)
> + bp->wol |= (MACB_WOL_HAS_ARP_PACKET | MACB_WOL_HAS_MAGIC_PACKET);
So bp->wol is the capabilities of the hardware?
And bp->wolopts is what has been enabled via ethtool?
I just wounder if it would be easier to understand is bp->wol was
renamed wol_caps, similar to bp->caps?
Andrew