Re: [PATCH net-next v4 1/6] dt-bindings: net: hisilicon-femac-mdio: convert to YAML

From: Yang Xiwen
Date: Thu Feb 22 2024 - 13:35:12 EST


On 2/23/2024 2:14 AM, Krzysztof Kozlowski wrote:
On 22/02/2024 13:43, Yang Xiwen via B4 Relay wrote:
From: Yang Xiwen <forbidden405@xxxxxxxxxxx>

For some FEMAC cores, MDIO bus is integrated to the MAC controller. So
We don't have a dedicated MDIO bus clock.
Hm, this means you miss compatibles for these different cores.


So you mean adding a new compatible like "hisilicon,hisi-femac-mdio-integrated" for these ones without dedicated clocks?



Also due to the PHY reset procedure, it's required to manage all clocks
and resets in the MAC controller driver. MAC controller clock can not be
shared with MDIO bus node in dts.

Mark the clock optional to resolve this problem.
I don't understand how making clock optional solves this problem. Clock
is still there. Whether driver handles it, does not affect the binding.

Best regards,
Krzysztof


--
Regards,
Yang Xiwen