Re: [PATCH net-next] ipv6/sit: Do not allocate stats in the driver

From: David Ahern
Date: Thu Feb 22 2024 - 12:32:34 EST


On 2/21/24 9:17 AM, Breno Leitao wrote:
> With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and
> convert veth & vrf"), stats allocation could be done on net core
> instead of this driver.
>
> With this new approach, the driver doesn't have to bother with error
> handling (allocation failure checking, making sure free happens in the
> right spot, etc). This is core responsibility now.
>
> Remove the allocation in the ipv6/sit driver and leverage the network
> core allocation.
>
> Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx>
> ---
> net/ipv6/sit.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>

Reviewed-by: David Ahern <dsahern@xxxxxxxxxx>