Re: [PATCH v6 0/5] selftests/resctrl: Add non-contiguous CBMs in Intel CAT selftest

[Reinette Chatre]

Hi Shuah,

Could you please consider this series for inclusion?

Thank you very much.

Reinette

On 2/16/2024 12:34 AM, Maciej Wieczor-Retman wrote:
> Non-contiguous CBM support for Intel CAT has been merged into the kernel
> with Commit 0e3cd31f6e90 ("x86/resctrl: Enable non-contiguous CBMs in
> Intel CAT") but there is no selftest that would validate if this feature
> works correctly. The selftest needs to verify if writing non-contiguous
> CBMs to the schemata file behaves as expected in comparison to the
> information about non-contiguous CBMs support.
> 
> The patch series is based on a rework of resctrl selftests that's
> currently in review [1]. The patch also implements a similar
> functionality presented in the bash script included in the cover letter
> of the original non-contiguous CBMs in Intel CAT series [3].
> 
> Changelog v6:
> - Add Reinette's reviewed-by tag to patch 2/5.
> - Fix ret type in noncont test.
> - Add a check for bit_center value in noncont test.
> - Add resource pointer check in resctrl_mon_feature_exists.
> - Fix patch 4 leaking into patch 3 by mistake.
> 
> Changelog v5:
> - Add a few reviewed-by tags.
> - Make some minor text changes in patch messages and comments.
> - Redo resctrl_mon_feature_exists() to be more generic and fix some of
>   my errors in refactoring feature checking.
> 
> Changelog v4:
> - Changes to error failure return values in non-contiguous test.
> - Some minor text refactoring without functional changes.
> 
> Changelog v3:
> - Rebase onto v4 of Ilpo's series [1].
> - Split old patch 3/4 into two parts. One doing refactoring and one
>   adding a new function.
> - Some changes to all the patches after Reinette's review.
> 
> Changelog v2:
> - Rebase onto v4 of Ilpo's series [2].
> - Add two patches that prepare helpers for the new test.
> - Move Ilpo's patch that adds test grouping to this series.
> - Apply Ilpo's suggestion to the patch that adds a new test.
> 
> [1] https://lore.kernel.org/all/20231215150515.36983-1-ilpo.jarvinen@xxxxxxxxxxxxxxx/
> [2] https://lore.kernel.org/all/20231211121826.14392-1-ilpo.jarvinen@xxxxxxxxxxxxxxx/
> [3] https://lore.kernel.org/all/cover.1696934091.git.maciej.wieczor-retman@xxxxxxxxx/
> 
> Older versions of this series:
> [v1] https://lore.kernel.org/all/20231109112847.432687-1-maciej.wieczor-retman@xxxxxxxxx/
> [v2] https://lore.kernel.org/all/cover.1702392177.git.maciej.wieczor-retman@xxxxxxxxx/
> [v3] https://lore.kernel.org/all/cover.1706180726.git.maciej.wieczor-retman@xxxxxxxxx/
> [v4] https://lore.kernel.org/all/cover.1707130307.git.maciej.wieczor-retman@xxxxxxxxx/
> [v5] https://lore.kernel.org/all/cover.1707487039.git.maciej.wieczor-retman@xxxxxxxxx/
> 
> Ilpo Järvinen (1):
>   selftests/resctrl: Add test groups and name L3 CAT test L3_CAT
> 
> Maciej Wieczor-Retman (4):
>   selftests/resctrl: Add a helper for the non-contiguous test
>   selftests/resctrl: Split validate_resctrl_feature_request()
>   selftests/resctrl: Add resource_info_file_exists()
>   selftests/resctrl: Add non-contiguous CBMs CAT test
> 
>  tools/testing/selftests/resctrl/cat_test.c    | 92 +++++++++++++++++-
>  tools/testing/selftests/resctrl/cmt_test.c    |  2 +-
>  tools/testing/selftests/resctrl/mba_test.c    |  2 +-
>  tools/testing/selftests/resctrl/mbm_test.c    |  6 +-
>  tools/testing/selftests/resctrl/resctrl.h     | 10 +-
>  .../testing/selftests/resctrl/resctrl_tests.c | 18 +++-
>  tools/testing/selftests/resctrl/resctrlfs.c   | 96 ++++++++++++++++---
>  7 files changed, 203 insertions(+), 23 deletions(-)
>