Re: [PATCH 0/4] sysctl: move sysctl type to ctl_table_header

From: Luis Chamberlain
Date: Thu Feb 22 2024 - 11:03:38 EST


On Thu, Feb 22, 2024 at 08:07:35AM +0100, Thomas Weißschuh wrote:
> Praparation series to enable constification of struct ctl_table further
> down the line.
> No functional changes are intended.
>
> These changes have been split out and reworked from my original
> const sysctl patchset [0].
> I'm resubmitting the patchset in smaller chunks for easier review.
> Each split-out series is meant to be useful on its own.
>
> Changes since the original series:
> * Explicit initializartion of header->type in init_header()
> * Some additional cleanups
>
> [0] https://lore.kernel.org/lkml/20231204-const-sysctl-v2-0-7a5060b11447@xxxxxxxxxxxxxx/

This all looks super sexy to me, but I'd love Eric's feedback on patch
series before merging as he may know some other facts over sysctl_mount_point
I might be missing.

Reviewed-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>

Luis