Re: [PATCH] serial: 8250: Use serial8250_do_set_termios for uartclk updating

From: Andy Shevchenko
Date: Thu Feb 22 2024 - 10:06:07 EST


On Thu, Feb 22, 2024 at 05:50:56PM +0300, Serge Semin wrote:
> The serial8250_update_uartclk() body was created based on the several
> method calls copied from the serial8250_do_set_termios() function. Seeing
> aside with some other things the later method can update the baud rate
> based on the new reference clock let's just call it instead thus
> simplifying the code a bit.
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Link: https://lore.kernel.org/linux-serial/ZczD7KPbeRnY4CFc@xxxxxxxxxxxxxxxxxx
> Signed-off-by: Serge Semin <fancer.lancer@xxxxxxxxx>

Thank you! This looks like a good simplification and turning to "one source" of
the same flow principle.

Assuming that it's working on your hardware,
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

--
With Best Regards,
Andy Shevchenko