Re: [PATCH v4 4/6] perf: imx_perf: add macro definitions for parsing config attr

From: Will Deacon
Date: Thu Feb 22 2024 - 07:24:02 EST


On Wed, Jan 31, 2024 at 01:58:09PM +0800, Xu Yang wrote:
> The user can set event and counter in cmdline and the driver need to parse
> it using 'config' attr value. This will add macro definitions to avoid
> hard-code in driver.
>
> Signed-off-by: Xu Yang <xu.yang_2@xxxxxxx>
>
> ---
> Changes in v4:
> - new patch
> ---
> drivers/perf/fsl_imx9_ddr_perf.c | 19 +++++++++++++------
> 1 file changed, 13 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_ddr_perf.c
> index 85aaaef7212f..94041f06c152 100644
> --- a/drivers/perf/fsl_imx9_ddr_perf.c
> +++ b/drivers/perf/fsl_imx9_ddr_perf.c
> @@ -52,6 +52,11 @@
> #define NUM_COUNTERS 11
> #define CYCLES_COUNTER 0
>
> +#define CONFIG_EVENT_MASK 0x00FF
> +#define CONFIG_EVENT_OFFSET 0
> +#define CONFIG_COUNTER_MASK 0xFF00
> +#define CONFIG_COUNTER_OFFSET 8

Can you move this patch earlier, please, so that the imx95 support can use
these new definitions immediately?

Will