Re: [PATCH 03/11] crypto: qce - Convert register r/w for skcipher via BAM/DMA

[Sricharan Ramabadhran]

On 12/14/2023 5:12 PM, Md Sadre Alam wrote:
> Convert register read/write for skcipher via BAM/DMA.
> with this change all the crypto register configuration
> will be done via BAM/DMA. This change will prepare command
> descriptor for all register and write it once.
>
> Signed-off-by: Md Sadre Alam <quic_mdalam@xxxxxxxxxxx>
> ---
>   drivers/crypto/qce/common.c   | 42 +++++++++++++++++++++--------------
>   drivers/crypto/qce/skcipher.c | 12 ++++++++++
>   2 files changed, 37 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/crypto/qce/common.c b/drivers/crypto/qce/common.c
> index 04253a8d3340..d1da6b1938f3 100644
> --- a/drivers/crypto/qce/common.c
> +++ b/drivers/crypto/qce/common.c

 Changes to common.c should have been in patch #2 ?
 Btw, if we are making cmd desc approach as default for all socs
 we should have it tested in all platforms ?

Regards,
 Sricharan