Re: [PATCH v3] i2c: imx: when being a target, mark the last read as processed

From: Wolfram Sang
Date: Thu Feb 22 2024 - 03:07:47 EST


On Thu, Feb 22, 2024 at 08:56:00AM +0100, Oleksij Rempel wrote:

> > > > When being a target, NAK from the controller means that all bytes have
> > > > been transferred. So, the last byte needs also to be marked as
> > > > 'processed'. Otherwise index registers of backends may not increase.
> > > >
> > > > Signed-off-by: Corey Minyard <minyard@xxxxxxx>
> > > > Tested-by: Andrew Manley <andrew.manley@xxxxxxxxxxxxxxx>
> > > > Reviewed-by: Andrew Manley <andrew.manley@xxxxxxxxxxxxxxx>
> > > > Reviewed-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> > > > [wsa: fixed comment and commit message to properly describe the case]
> > > > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> > >
> > > is this a fix?
> >
> > In deed, it is:
> >
> > Fixes: f7414cd6923f ("i2c: imx: support slave mode for imx I2C driver")
>
> Looks good :)
> Are any action needed on my side?

Nope. All tags are still valid, I'd say, because I didn't change any code.

Thanks!

Attachment: signature.asc
Description: PGP signature