Re: [PATCH net-next v8 08/13] netlink: specs: add ethnl PHY_GET command set

[Maxime Chevallier]

Hello Jakub,

On Wed, 21 Feb 2024 17:00:23 -0800
Jakub Kicinski <kuba@xxxxxxxxxx> wrote:

> On Tue, 20 Feb 2024 19:42:11 +0100 Maxime Chevallier wrote:
> > +      -
> > +        name: upstream-phy-index
> > +        type: u32  
> 
> The C define appears to be called:
> 
> 	ETHTOOL_A_PHY_UPSTREAM_INDEX,		/* u32 */
> 
> either it needs to gain the PHY_ or the spec needs to lose the phy-,
> otherwise C code gen gets upset:

I'll do it, sorry about that.

> 
> ethtool-user.c:689:10: error: ‘ETHTOOL_A_PHY_UPSTREAM_PHY_INDEX’ undeclared here (not in a function); did you mean ‘ETHTOOL_A_PHY_UPSTREAM_INDEX’?
>   689 |         [ETHTOOL_A_PHY_UPSTREAM_PHY_INDEX] = { .name = "upstream-phy-index", .type = YNL_PT_U32, },
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |          ETHTOOL_A_PHY_UPSTREAM_INDEX
> 
> Unfortunately ethtool in the in-between state where we can auto-gen
> user space code (or rather most of it) but the uAPI header is not
> auto-generated so we need to take extra care to keep things in sync :(

Is there anything I run for testing, so that I can make sure this
doesn't happen again ?

Thanks,

Maxime