Re: [PATCH 03/30] thread_info: tif_need_resched() now takes resched_t as param
From: Ankur Arora
Date: Wed Feb 21 2024 - 16:23:58 EST
Thomas Gleixner <tglx@xxxxxxxxxxxxx> writes:
> On Tue, Feb 20 2024 at 14:21, Ankur Arora wrote:
>> Thomas Gleixner <tglx@xxxxxxxxxxxxx> writes:
>>>> static __always_inline bool tif_need_resched_lazy(void)
>>>> {
>>>> return IS_ENABLED(CONFIG_PREEMPT_AUTO) &&
>>>> __tif_need_resched(TIF_NEED_RESCHED_LAZY);
>>>> }
>>>
>>> Yes please.
>>
>> As I wrote to Mark in the sibling subthread, I think exposing
>> the lazy variants outside of the scheduler isn't really needed.
>
> But having a proper wrapper inline in the scheduler code (local header)
> makes still a lot of sense.
Yeah, there are a few callsites where this will help. Will do.
Thanks
--
ankur