Re: [PATCH v2 1/2] pinctrl: renesas: Select CONFIG_IRQ_DOMAIN_HIERARCHY for pinctrl-rzg2l

[Geert Uytterhoeven]

Hi Claudiu,

On Thu, Feb 15, 2024 at 1:41 PM Claudiu <claudiu.beznea@xxxxxxxxx> wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
>
> The pinctrl-rzg2l driver uses APIs that are defined only if
> CONFIG_IRQ_DOMAIN_HIERARCHY=y (irq_chip_*_parent() APIs). On the ARCH_RZG2L
> CONFIG_IRQ_DOMAIN_HIERARCHY is selected anyway, e.g., by the
> CONFIG_ARM_GIC_V3. Even so, make it explicit at the driver level for a
> clearer view of the dependencies.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>

Thanks for your patch!

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Compile-testing on m68k reveals that you also need

    select GPIOLIB_IRQCHIP

So I will add that when queuing in renesas-pinctrl for v6.9.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds