Re: [PATCH] rtc: max31335: fix interrupt status reg

From: Nuno Sá
Date: Wed Feb 21 2024 - 08:33:23 EST


On Mon, 2024-02-19 at 11:16 +0200, Antoniu Miclaus wrote:
> Fix the register value comparison in the `max31335_volatile_reg`
> function for the interrupt status register.
>
> MAX31335_STATUS1 macro definition corresponds to the actual
> interrupt status register.
>
> Fixes: dedaf03b99d6 ("rtc: max31335: add driver support")
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>
> ---

Reviewed-by: Nuno Sa <nuno.sa@xxxxxxxxxx>

>  drivers/rtc/rtc-max31335.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-max31335.c b/drivers/rtc/rtc-max31335.c
> index 402fda8fd548..a2441e5c2c74 100644
> --- a/drivers/rtc/rtc-max31335.c
> +++ b/drivers/rtc/rtc-max31335.c
> @@ -204,7 +204,7 @@ static bool max31335_volatile_reg(struct device *dev, unsigned
> int reg)
>   return true;
>  
>   /* interrupt status register */
> - if (reg == MAX31335_INT_EN1_A1IE)
> + if (reg == MAX31335_STATUS1)
>   return true;
>  
>   /* temperature registers */