Re: [PATCH v1 1/1] driver core: Move fw_devlink stuff to where it belongs

[Andy Shevchenko]

On Wed, Feb 21, 2024 at 02:48:52PM +0200, Andy Shevchenko wrote:
> On Tue, Feb 20, 2024 at 06:08:56PM -0800, Saravana Kannan wrote:
> > On Tue, Feb 20, 2024 at 8:10 AM Andy Shevchenko
> > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > >
> > > A few APIs that belong specifically to the fw_devlink APIs
> > > - are exposed to others without need
> > > - prevents device property code to be cleaned up in the future
> > >
> > > Resolve this mess by moving fw_devlink code to where it belongs
> > > and hide from others.

..

> > The rest of the functions here are related to parents and children of
> > a fwnode. So, why is this function considered to be in the wrong
> > place?
> 
> When devlink was added it made a few fields in struct fwnode_handle.
> These fields have no common grounds with device properties. In particular
> struct device pointer is solely for devlinks and shouldn't be used with
> them. Hence this patch. TL;DR: they semantically do _not_ belong to
> the device property APIs.

On top of that for the 4+ years no new users appeared, so exporting them was
a clear mistake. Hence Fixes tags.

-- 
With Best Regards,
Andy Shevchenko