Re: [PATCH] ARM: fault: Implement copy_from_kernel_nofault_allowed()

From: Russell King (Oracle)
Date: Wed Feb 21 2024 - 06:30:24 EST


On Tue, Feb 20, 2024 at 10:39:15PM -0800, Kees Cook wrote:
> On Mon, Jan 22, 2024 at 05:12:38PM -0800, Kees Cook wrote:
> > Under PAN emulation when dumping backtraces from things like the
> > LKDTM EXEC_USERSPACE test[1], a double fault (which would hang a CPU)
> > would happen because of dump_instr() attempting to read a userspace
> > address. Make sure copy_from_kernel_nofault() does not attempt this
> > any more.
> >
> > Reported-by: Mark Brown <broonie@xxxxxxxxxx>
> > Link: https://lore.kernel.org/all/202401181125.D48DCB4C@keescook/ [1]
> > Suggested-by: "Russell King (Oracle)" <linux@xxxxxxxxxxxxxxx>
> > Cc: Russell King <linux@xxxxxxxxxxxxxxx>
> > Cc: Ard Biesheuvel <ardb@xxxxxxxxxx>
> > Cc: Wang Kefeng <wangkefeng.wang@xxxxxxxxxx>
> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > Cc: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>
> Russell, do you mind if I carry in my tree the 3 ARM patches I sent?
> They're mostly pretty trivial, and they've been in "Incoming"[1] for 2
> weeks but haven't shown up in -next yet. I'd really like them to get
> some soak time, and for them to reach the v6.9 merge window in time.

They can't show up in -next at the moment because the machine that hosts
my git tree is being moved between data centres. This was originally
flagged as a same-day (Tuesday) move, then next day, then it'll be back
online on Saturday. That's the last update that we've had.

As I don't believe my GPG key has the necessary signatures on, I don't
believe I can get a kernel.org account. I'm not even sure whether my
gpg key is even correct for that - and at the moment I just glaze over
reading the kernel.org gpg documentation.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!