Re: [PATCH stable 5.4 v3] net: bcmgenet: Fix EEE implementation

From: Greg KH
Date: Wed Feb 21 2024 - 06:03:20 EST


On Sun, Feb 11, 2024 at 05:48:57PM -0800, Florian Fainelli wrote:
> commit a9f31047baca57d47440c879cf259b86f900260c upstream
>
> We had a number of short comings:
>
> - EEE must be re-evaluated whenever the state machine detects a link
> change as wight be switching from a link partner with EEE
> enabled/disabled
>
> - tx_lpi_enabled controls whether EEE should be enabled/disabled for the
> transmit path, which applies to the TBUF block
>
> - We do not need to forcibly enable EEE upon system resume, as the PHY
> state machine will trigger a link event that will do that, too
>
> Fixes: 6ef398ea60d9 ("net: bcmgenet: add EEE support")
> Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
> Reviewed-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>
> Link: https://lore.kernel.org/r/20230606214348.2408018-1-florian.fainelli@xxxxxxxxxxxx
> Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> ---
> Changes in v2:
>
> - removed Changed-id

All now queued up, thanks.

greg k-h