RE: [PATCH net-next v6] bonding: rate-limit bonding driver inspect messages

[Praveen Kannoju]

> -----Original Message-----
> From: Simon Horman <horms@xxxxxxxxxx>
> Sent: 21 February 2024 04:09 PM
> To: Praveen Kannoju <praveen.kannoju@xxxxxxxxxx>
> Cc: j.vosburgh@xxxxxxxxx; andy@xxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx;
> pabeni@xxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Rajesh Sivaramasubramaniom
> <rajesh.sivaramasubramaniom@xxxxxxxxxx>; Rama Nichanamatlu <rama.nichanamatlu@xxxxxxxxxx>; Manjunath Patil
> <manjunath.b.patil@xxxxxxxxxx>
> Subject: Re: [PATCH net-next v6] bonding: rate-limit bonding driver inspect messages
> 
> On Wed, Feb 21, 2024 at 01:57:52PM +0530, Praveen Kumar Kannoju wrote:
> > Through the routine bond_mii_monitor(), bonding driver inspects and
> > commits the slave state changes. During the times when slave state
> > change and failure in aqcuiring rtnl lock happen at the same time, the
> > routine
> > bond_mii_monitor() reschedules itself to come around after 1 msec to
> > commit the new state.
> >
> > During this, it executes the routine bond_miimon_inspect() to
> > re-inspect the state chane and prints the corresponding slave state on to the console.
> > Hence we do see a message at every 1 msec till the rtnl lock is
> > acquired and state chage is committed.
> >
> > This patch doesn't change how bond functions. It only simply limits
> > this kind of log flood.
> >
> > Signed-off-by: Praveen Kumar Kannoju <praveen.kannoju@xxxxxxxxxx>
> > ---
> > v6:
> >   - Minor space additions addressed.
> > v5: https://lore.kernel.org/all/20240221050809.4372-1-praveen.kannoju@xxxxxxxxxx/
> >   - Redundant indentation addressed.
> > v4: https://lore.kernel.org/all/20240220050437.5623-1-praveen.kannoju@xxxxxxxxxx/
> >   - Rectification in the patch subject and versioning details.
> > v3: https://lore.kernel.org/lkml/20240219133721.4567-1-praveen.kannoju@xxxxxxxxxx/
> >   - Commit message is modified to provide summary of the issue, because of
> >     which rate-limiting the bonding driver messages is needed.
> > v2: https://lore.kernel.org/lkml/20240215172554.4211-1-praveen.kannoju@xxxxxxxxxx/
> >   - Use exising net_ratelimit() instead of introducing new rate-limit
> >     parameter.
> > v1:
> > https://lore.kernel.org/lkml/20240214044245.33170-1-praveen.kannoju@or
> > acle.com/
> > ---
> >  drivers/net/bonding/bond_main.c | 18 ++++++++++--------
> >  1 file changed, 10 insertions(+), 8 deletions(-)
> 
> Hi Praveen,
> 
> Thanks for addressing my review of v4.
> This version looks good to me.
> 
> Reviewed-by: Simon Horman <horms@xxxxxxxxxx>
> 
> ...

Thank you for the review, Simon, Hangbin and Jay.

-
Praveen.