Re: [PATCH v3 6/9] ARM: dts: aspeed: Harma: Add PDB temperature

[Krzysztof Kozlowski]

On 21/02/2024 10:39, Peter Yin wrote:
> Add PDB temperature sensor.
> 
> Signed-off-by: Peter Yin <peteryin.openbmc@xxxxxxxxx>
> ---
>  arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts
> index ca3052cce0e0..4d5d1c822fa3 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-harma.dts
> @@ -260,6 +260,11 @@ delta_brick@69 {
>  		compatible = "pmbus";
>  		reg = <0x69>;
>  	};
> +
> +	tmp75@49 {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Best regards,
Krzysztof